Bump activerecord dependency for Rails 6.1 #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `<<` to an ActiveModel::Errors message array in order to add an error is deprecated. Please call `ActiveModel::Errors#add` instead.
Closed
|
@sevenseacat I really appreciate your work on maintaining this project (at least it looks like you merged the last pull requests). Is there anything I can do to make you reviewing this PR easier? |
|
It looks like there also hasn't been a new release in some time - I'll try to work out how to make that happen now that we technically support Rails 6.1! |
|
@sevenseacat when can we expect the release for 6.1 support? |
|
@koleksiuk when I get some time to figure out how to do it! :D |
|
@koleksiuk I think I've done it right. v2.4.3 should be good to go. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using paranoia with Rails 6.1. This is a follow up of #501 and bumps the dependency in the gemspec, adds Rails 6.1 to the build matrix, and fixes a deprecation message.
@walski wrote in #501 (comment):