Use ActiveSupport.on_load to correctly re-open ActiveRecord::Base #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#335
I don't really know how to write a test for this. Although I have checked that it fixes the issue.
In Rails5
Rails.application.config.active_record.belongs_to_required_by_default = true
gets added innew_framework_defaults.rb
.When opening
ActiveRecord::Base
this gets overridden and requiresbelongs_to model, required: true
.The fix waits for
ActiveSupport.on_load(:active_record)
to load before openingActiveRecord::Base
.