Fixes a problem of ambiguous table names when using only_deleted method and joining tables that have a scope on with_deleted

[thromera]

Fixes #26 and #27 (that are still present).

This bug would happen when overriding sentinel with active field

# paranoid.rb
module Paranoid
  extend ActiveSupport::Concern

  # See index section here: https://github.com/radar/paranoia

  included do
    acts_as_paranoid column: :active, sentinel_value: true
    include Overrides
  end

  # If not defined in a separate module, Paranoia will be prepended before Paranoid, causing these methods to be later
  # in the call chain
  module Overrides
    def paranoia_restore_attributes
      {
        deleted_at: nil,
        active: true
      }
    end

    def paranoia_destroy_attributes
      {
        deleted_at: current_time_from_proper_timezone,
        active: nil
      }
    end
  end
end

#post.rb
class Post < ActiveRecord::Base
    include Paranoid

    belongs_to :author, -> {with_deleted}
    belongs_to :event, -> {with_deleted}

    validates_presence_of :author, :event
end

#author.rb
class Author < ActiveRecord::Base
    include Paranoid

    has_many :posts, -> {with_deleted}, dependent: :destroy
end

#event.rb
class Event < ActiveRecord::Base
    include Paranoid

    has_many :posts, -> {with_deleted}
end

Post.only_deleted.joins(:event)
2.2.3 :001 > Post.only_deleted.joins(:event)
  Post Load (10.1ms)  SELECT "posts".* FROM "posts" INNER JOIN "events" ON "events"."id" = "posts"."event_id" AND "events"."active" = ? WHERE ("active" IS NULL OR "active" != 't')  [["active", "t"]]
ActiveRecord::StatementInvalid: SQLite3::SQLException: ambiguous column name: active: SELECT "posts".* FROM "posts" INNER JOIN "events" ON "events"."id" = "posts"."event_id" AND "events"."active" = ? WHERE ("active" IS NULL OR "active" != 't')

[BenMorganIO]

?

[BenMorganIO]

?

[BenMorganIO]

The commit for this doesn't lead to a Github profile and isn't owned by anyone. I'm a bit skeptical security wise.

[thromera]

I'm currently in vacation, I will fix that next week, my git config was probably wrong at that time.

[thromera]

It should be fixed now. (I've also fixed the useless new lines.)

[BenMorganIO]

Cool. I'd love to get this in, but it looks like you need to rebase the latest changes from the core branch.

[thromera]

I'm closing this PR since I've messed up with my rebase. Sorry about that.
Good news is #379 should be OK to merge.