Fix restore with polymorphic has_one relationships #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restoring polymorphic has_one relationships errored because paranoia was
not correctly looking up the foreign_key.
Output from failing test -
ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: parent_model_id: SELECT "polymorphic_models".* FROM "polymorphic_models" WHERE ("polymorphic_models"."deleted_at" IS NOT NULL) AND (parent_model_id) ORDER BY "polymorphic_models"."id" ASC LIMIT 1
The test sets up a PolymorphicModel, which has_many parents. The
ParentModel then has a has_one relationship with PolymorphicModel. When
restoring, the foreign key is set as - `self.class.name.to_s.underscore_id`
which will be parent_model_id, instead of the :as option.
If the association object is a has_one relationship with an :as option, it will have a type attribute (see https://github.com/rails/docrails/blob/master/activerecord/lib/active_record/reflection.rb#L280). If this type attributes is present, that will be the type column on the polymorphic model. The foreign key can be found as an attribute on the association object.
johnnylai
added a commit
to johnnylai/paranoia
that referenced
this pull request
Dec 19, 2014
|
Let me know if there's anything I can do to help get this beauty merged! :) |
|
Any word on when this might get merged in? |
|
This was merged. Thanks very much. 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoring polymorphic
has_onerelationships errored because paranoia wasnot correctly looking up the foreign_key.
Output from failing test -
The test sets up a
PolymorphicModel, whichhas_many :parents. TheParentModelthen has ahas_onerelationship withPolymorphicModel. Whenrestoring, the foreign key is set as -
self.class.name.to_s.underscore_idwhich will be
parent_model_id, instead of the correct:asoption.To fix:
If the association object is a
has_onerelationship with an:asoption,it will have a
typeattribute (seehttps://github.com/rails/docrails/blob/master/activerecord/lib/active_record/reflection.rb#L280).
If this
typeattributes is present, it will be the type column on thepolymorphic model. The foreign key can be found as an attribute on
the association object.
This should fix #174. Solution is based off of @hamidumi 's suggestions in #174.