Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSpec 3.x deprecations #156

Merged
merged 3 commits into from
Aug 29, 2014
Merged

Conversation

lime
Copy link
Contributor

@lime lime commented Aug 28, 2014

The failure_message_for_should syntax is deprecated in RSpec 3.

This could of course be merged into the rails3 branch as well. Do you want me to make a separate pull request for that?

@radar
Copy link
Collaborator

radar commented Aug 29, 2014

Thanks for this @lime. The code looks good to me. I should be able to merge it just fine into the rails3 branch,

radar added a commit that referenced this pull request Aug 29, 2014
@radar radar merged commit fe70628 into rubysherpas:rails4 Aug 29, 2014
radar pushed a commit that referenced this pull request Aug 29, 2014
@lime
Copy link
Contributor Author

lime commented Sep 1, 2014

Awesome! Also, if I may bug you, could we get a version 2.0.3 at some point? ;)

@lime lime deleted the rspec-deprecations branch September 2, 2014 10:29
@radar
Copy link
Collaborator

radar commented Sep 8, 2014

I'll release 2.0.3 once #102 is fixed.

@schlick
Copy link

schlick commented Nov 28, 2014

Sadly, the RSpec 2 compatibility doesn't work for me with RSpec 2.14 (and paranoia 2.0.3). I get:

undefined method failure_message'`

I'll have a play around and see if I can easily get it to work.

@lime
Copy link
Contributor Author

lime commented Dec 2, 2014

Hm, I realise now that I might have messed up... 😬 I thought I tried it out with RSpec 2 as well but, embarrassingly, I may have forgotten.

I'll have time to debug it later in the week, unless you manage to fix it before that. ;)

@schlick
Copy link

schlick commented Dec 2, 2014

I had a play around with it but I couldn't get something satisfactory. In the end I monkey patched it in my app.

@lime
Copy link
Contributor Author

lime commented Dec 23, 2014

#197 should do the trick. Sorry about that. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants