-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RSpec 3.x deprecations #156
Conversation
Thanks for this @lime. The code looks good to me. I should be able to merge it just fine into the rails3 branch, |
Awesome! Also, if I may bug you, could we get a version 2.0.3 at some point? ;) |
I'll release 2.0.3 once #102 is fixed. |
Sadly, the RSpec 2 compatibility doesn't work for me with RSpec 2.14 (and paranoia 2.0.3). I get:
I'll have a play around and see if I can easily get it to work. |
Hm, I realise now that I might have messed up... 😬 I thought I tried it out with RSpec 2 as well but, embarrassingly, I may have forgotten. I'll have time to debug it later in the week, unless you manage to fix it before that. ;) |
I had a play around with it but I couldn't get something satisfactory. In the end I monkey patched it in my app. |
#197 should do the trick. Sorry about that. :) |
The
failure_message_for_should
syntax is deprecated in RSpec 3.This could of course be merged into the
rails3
branch as well. Do you want me to make a separate pull request for that?