Skip to load commented out words

[hsbt]

What was the end-user or developer problem that led to this PR?

Fixes #7393

The current YAML serializer couldn't handle commented out words.

What is your fix for the problem, implemented in this PR?

Skip to load after # symbol.

Make sure the following tasks are checked

• Describe the problem / feature
• Write tests for features and bug fixes
• Write code to solve the problem
• Make sure you follow the current code style and write meaningful commit messages without tags

[williantenfen]

@hsbt sorry If I'm getting on your way... I'm just trying to contribute with something..

does it make sense to use a regex for this? or update the current ones?

I think I manage to pass some specs with something:

REMOVE_COMMENT_REGEX = /
      ^
      (["']?)  # optional opening quote
      (.*?)  # match for characters between quotes
      \1     # matching closing quote
      \s*    # Optional whitespace characters after the closing quote
      (?:\#(.*))?  # optional comment starting with '#'
      $
    /xo

  ...
  # and then call it when needed:


         if val == "[]" # empty array
              val = []
            else
              val = val.match(REMOVE_COMMENT_REGEX)[2]
            end

would pass this:

it "ignore comments" do
      yaml = <<~YAML
        ---
        Foo: "Lobster shouldn't go # should stay!" # test
        Bar: Something without quote! # another comment
        Mick: "Not... but crambs yes!"#test
        empty:
      YAML

      hash = {
        "Foo" => "Lobster shouldn't go # should stay!",
        "Bar" => "Something without quote!",
        "Mick" => "Not... but crambs yes!",
        "empty" => {},
      }

      expect(serializer.load(yaml)).to eq(hash)
    end

this would support # as regular text inside quotes..

I can try a PR as well, if you don't mind..

[hsbt]

@williantenfen Thanks for your support! I only focused configuration file for rubygems. If you interest to improve this PR, feel free to submit your idea and changes 👍

[segiddins]

given this is operating on a new string, we can avoid the array & string allocations by using val.sub!(/#.*/, "")