Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds notifications for supes/admin for resolved followups #1611

Merged
merged 2 commits into from
Jan 24, 2021
Merged

Conversation

scottolsen
Copy link
Collaborator

@scottolsen scottolsen commented Jan 24, 2021

What github issue is this PR for, if any?

Resolves #1507

What changed, and why?

Supervisors and admins will now be notified when a volunteer resolves a followup
that they created. There is a new "Inbox" link in the sidebar and an unread
badge count shows if there are unread notifications. Clicking a notification
will mark it unread and take the user to the edit case contact screen.

How will this affect user permissions?

  • Volunteer permissions:
  • Supervisor permissions:
  • Admin permissions:

How is this tested? (please write tests!) 💖💪

Yes!

Screenshots please :)

https://youtu.be/HYglOGsEqpE

image
image

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

This adds the `noticed` gem to create notifications. Now when a followup
is resolved, we will create a notification for the creator of the
followup, unless the creator and the resolver are the same user.

https://github.com/excid3/noticed
@github-actions github-actions bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Jan 24, 2021
@Zrrrpy Zrrrpy temporarily deployed to casa-issue-1507-ksvcbl7c7clb0z January 24, 2021 21:03 Inactive
Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow wow WOW! Very nice :) 💪✨🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

supervisors/admins are notified when volunteer closes followup generated by them
3 participants