Synchronize all accesses to @done

* So it is trivially correct. * Performance seems the same overall.
ruby · May 15, 2022 · 5e0d8e1 · 5e0d8e1
1 parent 4baee63
commit 5e0d8e1
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/timeout.rb b/lib/timeout.rb
@@ -67,11 +67,13 @@ def initialize(thread, timeout, exception_class, message)
       @message = message
 
       @mutex = Mutex.new
-      @done = false
+      @done = false # protected by @mutex
     end
 
     def done?
-      @done
+      @mutex.synchronize do
+        @done
+      end
     end
 
     def expired?(now)