use instance_method to get method object
#11965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of `method()`. There is a bug around `define_method`, so this patch is workaround.
module M
def foo = 1
self.extend M
end
3.times{
module M
alias foo2 foo
remove_method :foo
def foo = 2
ensure
alias foo foo2
remove_method :foo2
end
p M.foo
original_foo = M.method(:foo)
M.class_eval do
remove_method :foo
def foo = 3
end
M.class_eval do
remove_method :foo
define_method :foo, original_foo
end
}This is repro-code ( |
|
This patch solves this kind of error: |
|
I have created and merged ruby/error_highlight#56 |
ko1
added a commit
to ko1/ruby
that referenced
this pull request
Oct 31, 2024
`me->defined_class` should be 0 for method entries of Modules. The current implementation violates this condition when the aliased object was complemented cme. This patch checks this condition and fix ruby#11965 (comment)
ko1
added a commit
to ko1/ruby
that referenced
this pull request
Oct 31, 2024
`me->defined_class` should be 0 for method entries of Modules. This patch checks this condition and fix ruby#11965 (comment)
ko1
added a commit
that referenced
this pull request
Nov 1, 2024
`me->defined_class` should be 0 for method entries of Modules. This patch checks this condition and fix #11965 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of
method().There is a bug around
define_method, so this patch is workaround.