Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define only name Singleton::SingletonClassMethods #978

Merged
merged 1 commit into from
May 6, 2022

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Apr 12, 2022

Singleton::SingletonClassMethods is internal module.
But it does exist.
Therefore, I propose to register only the module name.
This module name will prevent the problem of a non-existent module name when the RBS is mechanically generated.
If this module name does not exist, the developer will have to write code to work around the error.

Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pocke pocke merged commit 5211a89 into ruby:master May 6, 2022
@ksss ksss deleted the singleton-class-methods branch May 6, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants