Const types as literal types #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of `node_type`
Because this logic is primarily intended for CDECL.
The `node_type` is used practically only for method arguments. Change the name to make the difference between `literal_to_type` and `node_type` clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for multi fix.
All commit includes testing code.
Currently, const(CDECL node) use the same type resolution as the optional arguments of the method(
node_type).However, most constants are immutable, and it is unnatural to treat them the same as method optional arguments.
For example
I've modified the case of const and optional arguments to be separated, and const are now attempted to be resolved as literals like method return type.