Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Prime signature #934

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Fix Prime signature #934

merged 2 commits into from
Mar 22, 2022

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Mar 22, 2022

Fix #924

And I reimplement testing code using by generator.

$ bundle exec rake 'generate:stdlib_test[Prime]'

It will also be possible to run tests on Ruby 3.0 over.

soutaro
soutaro reviewed Mar 22, 2022
View reviewed changes
Gemfile
@@ -18,6 +18,7 @@ gem "goodcheck"
gem "dbm"
gem 'digest'
gem 'tempfile'
gem "prime"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

soutaro
soutaro approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👏

@soutaro soutaro merged commit ddad41d into ruby:master Mar 22, 2022
@ksss ksss deleted the prime branch March 22, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prime's signature is broken
2 participants
@ksss @soutaro