Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Net::HTTP] Add timeout errors #892

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Conversation

raosush
Copy link
Contributor

@raosush raosush commented Feb 2, 2022

Description

The current rbs file for Net::HTTP contained only ProtocolErrors. Hence, this PR adds the missing Timeout errors.

Changes

  • Added timeout as a dependency, since OpenTimeout, ReadTimeout, WriteTimeout are subclasses of Timeout::Error. Ref
  • The corresponding Timeout errors have been added into net-http.rbs

Fixes: #843

@soutaro
Copy link
Member

soutaro commented Feb 3, 2022

Thank you, @raosush !

Could you run rbs annotate stdlib/net-http to import the RDoc?

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@raosush
Copy link
Contributor Author

raosush commented Feb 4, 2022

Thank you, @raosush !

Could you run rbs annotate stdlib/net-http to import the RDoc?

@soutaro sir, running the annotate command does not annotate the timeout classes since there is no RDoc available for them. Ref: https://ruby-doc.org/stdlib-2.7.1/libdoc/net/pop/rdoc/Net/Protocol.html

@soutaro
Copy link
Member

soutaro commented Feb 4, 2022

@raosush Could you try again using ruby 3.1? (It finds docs on my computer.)

@raosush
Copy link
Contributor Author

raosush commented Feb 4, 2022

@raosush Could you try again using ruby 3.1? (It finds docs on my computer.)

@soutaro yes sir. On Ruby 3.1 I was able to fetch RDoc documentation and annotate it.

@raosush raosush requested a review from soutaro February 4, 2022 18:07
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@soutaro soutaro merged commit 3edb372 into ruby:master Feb 7, 2022
@raosush raosush deleted the add_net_timeout_errors branch February 7, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Net::HTTP Timeout Errors are missing
2 participants