-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Net::HTTP] Add timeout errors #892
Conversation
Thank you, @raosush ! Could you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
@soutaro sir, running the annotate command does not annotate the timeout classes since there is no RDoc available for them. Ref: https://ruby-doc.org/stdlib-2.7.1/libdoc/net/pop/rdoc/Net/Protocol.html |
@raosush Could you try again using ruby 3.1? (It finds docs on my computer.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
Description
The current
rbs
file forNet::HTTP
contained onlyProtocolError
s. Hence, this PR adds the missingTimeout
errors.Changes
timeout
as a dependency, sinceOpenTimeout
,ReadTimeout
,WriteTimeout
are subclasses ofTimeout::Error
. RefTimeout
errors have been added intonet-http.rbs
Fixes: #843