Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid a mixture of Array#filter and Array#select #820

Merged
merged 1 commit into from
Nov 7, 2021
Merged

Avoid a mixture of Array#filter and Array#select #820

merged 1 commit into from
Nov 7, 2021

Conversation

kymmt90
Copy link
Contributor

@kymmt90 kymmt90 commented Nov 5, 2021 •
edited
Loading

Although Array#select is an alias of Array#filter, it would be clearer to use only filter in the examples for readers.

@kymmt90
Avoid a mixture of Array#filter and Array#select
ea67395 
Although `Array#select` is an alias of `Array#filter`, it would be clearer to use either only `filter` or `select` in the examples for readers.
@pocke pocke enabled auto-merge November 7, 2021 09:04
pocke
pocke approved these changes Nov 7, 2021
View reviewed changes
Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement!

@pocke pocke merged commit 9c43ce0 into ruby:master Nov 7, 2021
@kymmt90 kymmt90 deleted the patch-1 branch November 7, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocke pocke pocke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kymmt90 @pocke