Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Array#[] to receive Range of optional Integer #732

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Allow Array#[] to receive Range of optional Integer #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/array.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ class Array[unchecked out Elem] < Object
#
def []: (int index) -> Elem
| (int start, int length) -> ::Array[Elem]?
| (::Range[::Integer] range) -> ::Array[Elem]?
| (::Range[::Integer?] range) -> ::Array[Elem]?

# Element Assignment --- Sets the element at `index`, or replaces a subarray
# from the `start` index for `length` elements, or replaces a subarray specified
Expand Down Expand Up @@ -486,9 +486,9 @@ class Array[unchecked out Elem] < Object
| (int start, int length, Elem obj) -> Elem
| (int start, int length, ::Array[Elem]) -> ::Array[Elem]
| (int start, int length, nil) -> nil
| (::Range[::Integer], Elem obj) -> Elem
| (::Range[::Integer], ::Array[Elem]) -> ::Array[Elem]
| (::Range[::Integer], nil) -> nil
| (::Range[::Integer?], Elem obj) -> Elem
| (::Range[::Integer?], ::Array[Elem]) -> ::Array[Elem]
| (::Range[::Integer?], nil) -> nil

# See also Enumerable#all?
#
Expand Down
4 changes: 4 additions & 0 deletions test/stdlib/Array_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ def test_aref
[1,2,3], :[], 0...1
assert_send_type "(Range[Integer]) -> nil",
[1,2,3], :[], 5..8
assert_send_type "(Range[Integer?]) -> Array[Integer]",
[1,2,3], :[], 0...nil
end

def test_aupdate
Expand All @@ -121,6 +123,8 @@ def test_aupdate
[1,2,3], :[]=, 0...2, [-1]
assert_send_type "(Range[Integer], nil) -> nil",
[1,2,3], :[]=, 0...2, nil
assert_send_type "(Range[Integer?], Integer) -> Integer",
[1,2,3], :[]=, 0..nil, -1
end

def test_all?
Expand Down