YAML

[PanosCodes]

No description provided.

[soutaro]

Hash[untyped, untyped] | String | Array[untyped] ??
Or I think returning just untyped is enough.

[soutaro]

Hash[untyped, untyped]

[soutaro]

Hi!

Rewriting Hash to Hash[untyped, untyped] would make the test pass.
However, I'm not very sure if returning hash types makes much sense, because this is serialization and untyped should appear almost everywhere...

[PanosCodes]

Hi!

Rewriting Hash to Hash[untyped, untyped] would make the test pass.
However, I'm not very sure if returning hash types makes much sense, because this is serialization and untyped should appear almost everywhere...

Thank you for your feedback.
So you suggest when a there are unknown types inside the hash instead of Hash[untyped, untyped] we should return untyped ?

[soutaro]

Oh no, I'm sorry. It is about DBM. I was confusing a bit about if it was about YAML.
Hash[untyped, untyped] would make sense for method which returns a hash.

[PanosCodes]

/__w/rbs/rbs/lib/rbs/errors.rb:140:in `check!': /__w/rbs/rbs/stdlib/yaml/store.rbs:32:0...53:3: Could not find super class: PStore (RBS::NoSuperclassFoundError)

The YAML Store depends on PStore for witch we don't have signature. That is probably the reason the tests fail.
Here is a PR from PStore #443

[PanosCodes]

/__w/rbs/rbs/lib/rbs/errors.rb:140:in `check!': /__w/rbs/rbs/stdlib/yaml/dbm.rbs:61:2...220:5: Could not find super class: ::DBM (RBS::NoSuperclassFoundError)

YAML also depends on DBM and tries to find it.
Here is PR for that #441

[PanosCodes]

@soutaro Any idea why it fails to find DBM ? I believe #441 should have fixed that.

/__w/rbs/rbs/lib/rbs/errors.rb:140:in `check!': /__w/rbs/rbs/stdlib/yaml/dbm.rbs:61:2...220:5: Could not find super class: ::DBM (RBS::NoSuperclassFoundError)

[soutaro]

@PanosCodes Could you rebase your branch on the latest HEAD and moving your RBS files under stdlib/yaml/0 directory?

Standard library signatures are moved in #405. (I'm sorry for breaking your work with that. 🙇‍♂️)

[PanosCodes]

@PanosCodes Could you rebase your branch on the latest HEAD and moving your RBS files under stdlib/yaml/0 directory?

Standard library signatures are moved in #405. (I'm sorry for breaking your work with that. 🙇‍♂️)

No worries 😄 But it still throws the same error 🤔

[soutaro]

@PanosCodes I got it. 💪

You need to specify -r dbm -r pstore to command line to start the validation.

$ bundle exec rbs -r yaml -r dbm -r pstore validate

# You can add the following lines to Rakefile to let `rake validate` run for YAML.

if lib == ["yaml"]
  lib << "dbm"
  lib << "pstore"
end

[PanosCodes]

@PanosCodes I got it. 💪

You need to specify -r dbm -r pstore to command line to start the validation.

$ bundle exec rbs -r yaml -r dbm -r pstore validate

# You can add the following lines to Rakefile to let `rake validate` run for YAML.

if lib == ["yaml"]
  lib << "dbm"
  lib << "pstore"
end

Awesome , thank you for looking into that 👍

[soutaro]

Thanks! @PanosCodes