rbs prototype rb guess return value type even if "def" has multiple statements
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
commented
Jun 14, 2020
| @@ -408,9 +420,11 @@ def literal_to_type(node) | |||
|
|
|||
| def types_to_union_type(types) | |||
| return untyped if types.empty? | |||
| return untyped if types.include?(untyped) | |||
There was a problem hiding this comment.
Previously Something | untyped is squashed to untyped. But I think Something | untyped is useful for humans when reviewing the generated types. (The original idea is the type profiler.)
So it will not be squashed by this pull request.
pocke
commented
Jun 14, 2020
| @@ -393,7 +405,7 @@ def literal_to_type(node) | |||
| value_types << literal_to_type(v) | |||
| end | |||
|
|
|||
| if key_types.all? { |t| t.is_a?(Types::Literal) } | |||
| if !key_types.empty? && key_types.all? { |t| t.is_a?(Types::Literal) } | |||
There was a problem hiding this comment.
An empty record is syntax error, so it should be Hash[untyped, untyped] instead.
soutaro
reviewed
Jun 14, 2020
| @@ -128,6 +128,9 @@ def assert_write(decls, string) | |||
| writer.write(decls) | |||
|
|
|||
| assert_equal string, writer.out.string | |||
|
|
|||
| # Check syntax error | |||
| RBS::Parser.parse_signature(writer.out.string) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Since #209,
rbs prototype rbhas been aware of returned type. But it only can be aware of the method body has only one statement and it is literal.For example:
What is this pull request
This pull request solves the
bad: () -> untyped. It will bebad: () -> "foo".Previously
rbs prototype rbonly guessed returned types for methods that contain only one literal.But it will guess types for
returnstatements and the last statement of the method.