Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-hardcode repo name in test suite #2128

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

amomchilov
Copy link
Contributor

These tests inadvertently require that the devs working on RBS have it checked out in a folder called rbs.

This becomes an issue if a dev wants to check out the RBS repo under a different name, such as to check out multiple worktrees at a time.

git worktree add ../rbs1
git worktree add ../rbs1

@amomchilov amomchilov mentioned this pull request Dec 6, 2024
7 tasks
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@soutaro soutaro added this pull request to the merge queue Dec 9, 2024
@soutaro soutaro added this to the RBS 3.8 milestone Dec 9, 2024
Merged via the queue into ruby:master with commit 305389b Dec 9, 2024
18 checks passed
@soutaro soutaro added the Released PRs already included in the released version label Dec 19, 2024
@amomchilov amomchilov deleted the repo-name-in-tests branch January 6, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants