Allow alias to module-self-type from module #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
commented
Aug 2, 2024
| @@ -2686,4 +2686,23 @@ module Bar : Foo | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| def test_alias__to_module_self_indierect_method | |||
| SignatureManager.new(system_builtin: false) do |manager| | |||
There was a problem hiding this comment.
It's really complicated to reproduce the problem.
Simply build_instance(TypeName("::Kernel")) doesn't fail, because the self_types are given through build_instance method.
Building ::Foo instance requires some of the methods of its module-self-type, ::Object. ::Object instance type requires the instance methods of ::Kernel, but it's done other than #build_instance method. So, the module-self-type methods are not injected, and causes the problem.
soutaro
commented
Aug 2, 2024
| @@ -86,6 +86,19 @@ def define_instance(definition, type_name, subst) | |||
| one_ancestors = ancestor_builder.one_instance_ancestors(type_name) | |||
| methods = method_builder.build_instance(type_name) | |||
|
|
|||
| self_type_methods = one_ancestors.each_self_type.with_object({}) do |self_type, hash| #$ Hash[Symbol, Definition::Method] | |||
There was a problem hiding this comment.
We cannot simply inject the self_types methods to the result methods/definition, because the self_types methods may include other inherited methods, like #initialize and having them in the module is something unexpected.
soutaro
force-pushed
the
alias-module-self-type
branch
from
84f7b37 to
3fe6743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining an alias from a module to its module-self-type causes an error like
This PR fixes the problem.