Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Delegator object #1682

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Support Delegator object #1682

merged 1 commit into from
Dec 18, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Dec 17, 2023

The Delegator class intentionally rewrites #methods, but the rewrite does not work in Test.call and the type using interface does not pass the test.

The #respond_to? is not rewritten, so the Delegator class is supported by using #respond_to? instead of #methods.

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
We should have used respond_to?!

@soutaro soutaro added this to the RBS 3.4 milestone Dec 18, 2023
@soutaro soutaro added this pull request to the merge queue Dec 18, 2023
Merged via the queue into ruby:master with commit 3a5708e Dec 18, 2023
23 checks passed
@ksss ksss deleted the test-delegator branch December 18, 2023 09:33
soutaro added a commit that referenced this pull request Dec 20, 2023
This reverts commit 3a5708e, reversing
changes made to 0c0eac6.
@soutaro soutaro added the Released PRs already included in the released version label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants