Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix; .respond_to is no longer used in Rbs::Test::Errors#inspect_ #1650

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Bugfix; .respond_to is no longer used in Rbs::Test::Errors#inspect_ #1650

merged 1 commit into from
Nov 27, 2023

Conversation

sampersand
Copy link
Contributor

@sampersand sampersand commented Nov 26, 2023 •
edited
Loading

This fixes a bug in the testing suite where .respond_to? is being used on BlankSlate subclass instances.

@sampersand sampersand changed the title Bugfix; .respond_to is no longer used in Rbs::Test::Errors#inspect_ Bugfix; .respond_to is no longer used in Rbs::Test::Errors#inspect_ Nov 26, 2023
soutaro
soutaro approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@soutaro soutaro added this to the RBS 3.4 milestone Nov 27, 2023
@soutaro soutaro added this pull request to the merge queue Nov 27, 2023
Merged via the queue into ruby:master with commit b9930cb Nov 27, 2023
24 checks passed
soutaro added a commit that referenced this pull request Dec 20, 2023
@soutaro
Revert "Merge pull request #1650 from sampersand/swesterman/23-11-26/…
82c246c 
…bugfix-RBS.Test.Errors.inspect_"

This reverts commit b9930cb, reversing
changes made to a15863f.
@soutaro soutaro added the Released PRs already included in the released version label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@sampersand @soutaro