Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Marshal #1524

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Update Marshal #1524

merged 2 commits into from
Sep 22, 2023

Conversation

sampersand
Copy link
Contributor

@sampersand sampersand commented Sep 19, 2023 •
edited
Loading

This updates Marshal's definition, as well as its tests.

More specifically this has the following changes:

  • Marshal::MAJOR_VERSION: Moved definition inside the module
  • Marshal::MINOR_VERSION: Moved definition inside the module
  • Marshal.dump: It's now a self?., port is now a _Writer (and is the return value), andlimit is now int? not Integer.
  • Marshal.load: source is now string | _Source, and the proc field is no longer a literal proc (but rather a interface _Proc[A]; def call: (untyped) -> A end)

@sampersand sampersand force-pushed the swesterman/23-09-06/marshal branch from 4a9acb7 to 6c5c342 Compare September 19, 2023 04:32
@sampersand sampersand force-pushed the swesterman/23-09-06/marshal branch from 6c5c342 to 7768d38 Compare September 19, 2023 04:35
@sampersand sampersand marked this pull request as ready for review September 19, 2023 04:38
soutaro
soutaro approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@soutaro soutaro added this pull request to the merge queue Sep 21, 2023
@soutaro soutaro added this to the RBS 3.3 milestone Sep 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 21, 2023
@soutaro soutaro added this pull request to the merge queue Sep 22, 2023
Merged via the queue into ruby:master with commit abcc97d Sep 22, 2023
@soutaro soutaro added the Released PRs already included in the released version label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@sampersand @soutaro