Updated Kernel#Hash #1436
Closed
Updated Kernel#Hash #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampersand
force-pushed
the
swesterman/23-08-18/update-Kernel#Hash
branch
from
56f9c72 to
7cc53df
Compare
ParadoxV5
reviewed
Aug 19, 2023
| @@ -488,7 +488,7 @@ module Kernel : BasicObject | |||
| # Hash(nil) # => {} | |||
| # Hash([]) # => {} | |||
| # | |||
| def self?.Hash: [K, V] (Object x) -> ::Hash[K, V] | |||
| def self?.Hash: [K, V] (nil | [] | _ToHash[K, V]) -> Hash[K, V] | |||
There was a problem hiding this comment.
I was debating on whether I should make a separate
(nil | []) -> {}case, but I decided against it.
No need to, at all, since nil and empty arrays already have #to_h, let their own RBSs do the [K, V] magic. (I’ll check RBS for NilClass#to_h)
Suggested change
| def self?.Hash: [K, V] (nil | [] | _ToHash[K, V]) -> Hash[K, V] | |
| def self?.Hash: [K, V] (_ToHash[K, V]) -> Hash[K, V] |
There was a problem hiding this comment.
NilClass#to_h gives Hash[untyped, untyped] 👍
There was a problem hiding this comment.
It's not the exact same @ParadoxV5—_ToHash requires to_hash, not to_h. So the nil | [] case is distinct.
|
Consolidated in #1445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
Kernel#Hash's signature.This is probably the second-simplest of the kernel conversion methods, after
Kernel#String:nilor an empty array, an empty hash is returned..to_hashis called on the object.I was debating on whether I should make a separate
(nil | []) -> {}case, but I decided against it. (Using[]/{}literals in practice is pretty difficult, as it's aHash[bot, bot].)