Super class should be absolute paths. #1415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The signature generated by the
rbs prototype runtime
for theActiveSupport::Logger
as follows is unreadable due to an error.Detected recursive ancestors: ::ActiveSupport::Logger < ::ActiveSupport::Logger (RBS::RecursiveAncestorError)
In the actual Rails code, super class are specified by absolute paths, as shown below.
https://github.com/rails/rails/blob/2942958827f1934dfcba284d074e6d61104d3e7c/activesupport/lib/active_support/logger.rb#L7-L8
Proposal
I propose to solve this problem by specifying the superclass as an absolute path even in the
rbs prototype runtime
.There may be other similar problems, but I have limited the impact to specifying the superclass only.