Add rbs_ prefix to skip function #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function name `skip` is too common and it confliects macOS's libsystem_c.dylib. Though it doesn't cause a problem under two-level namespaces, it causes a crash with flat_namespace or other environments.
soutaro
force-pushed
the
add-prefix-to-skip
branch
from
9abe30e to
9c25d55
Compare
soutaro
added a commit
that referenced
this pull request
Jan 6, 2023
Add rbs_ prefix to skip function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function name
skipis too common and it confliects macOS'slibsystem_c.dylib. Though it doesn't cause a problem under two-level
namespaces, it causes a crash with flat_namespace or other environments.