Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method commenting #1027

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Fix method commenting #1027

merged 1 commit into from
Jun 20, 2022

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Jun 9, 2022

The result of the comment is broken because there is no distinction between a code ending comment and a comment without a code.


t.rb

# Foo doc
module Foo # :nodoc:
  # foo doc
  def foo
  end
end

Before

module Foo
  # Foo doc
  # :nodoc:
  # foo doc
  def foo: () -> nil
end

After

# Foo doc
module Foo
  # foo doc
  def foo: () -> nil
end

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@soutaro soutaro merged commit a3fcef7 into ruby:master Jun 20, 2022
@ksss ksss deleted the prototype-rb branch June 21, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants