Remove support for OpenSSL < 1.0.1 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agreed. We should merge this after Ruby 2.4.0 release.
It's enough for our decision. |
rhenium
force-pushed
the
topic/drop-openssl-098-and-100
branch
from
4843650 to
92a1ebe
Compare
rhenium
force-pushed
the
topic/drop-openssl-098-and-100
branch
2 times, most recently
from
1335f2c to
7afec32
Compare
They are no longer receiving security updates from the OpenSSL development team since 2015-12. We have kept basic compatibility until now because RHEL 5 still uses an (heavily modified) OpenSSL 0.9.8e. The RHEL 5 will reach EOL on 2017-03, thus it is now safe to assume nobody is still using such old versions of OpenSSL.
rhenium
force-pushed
the
topic/drop-openssl-098-and-100
branch
from
7afec32 to
4eb4b32
Compare
|
Will merge to master. -400 lines! |
|
Great work, @rhenium! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are skipping all tests if built with < 1.0.01. This is really bad. Probably we can fix them. ...but who really uses such an out-dated version?
Support for OpenSSL 0.9.8/1.0.0 series from the OpenSSL development team has finally ended last year, on 2015-122.
We have kept basic compatibility (no missing symbols, SSL seems to work) with OpenSSL 0.9.8 mainly for RHEL 5 (and its derivatives) that ships with heavily modified OpenSSL 0.9.8e. The RHEL 5 will reach EOL on 2017-03. We are already ignoring 0.9.8 bundled in OS X3. As far as I know, there are no other public re-distributions of OpenSSL 0.9.8 or 1.0.0 series with security bug fixes, so, it must be safe to assume nobody is still using them.
I'm not going to merge immediately, and thinking of doing this after Ruby 2.4 release.
Thoughts?