Prefer String#unpack1 #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Maumagnaguagno Can you describe why we should use it? |
|
@hsbt I filled the blank description in the top comment. |
|
Note that this PR is similar to previous commits within this organization, see ruby/ruby@5de6e25, ruby/securerandom@5460a18 and ruby/reline@179c52b. |
|
Can you remove the diff in |
Maumagnaguagno
force-pushed
the
unpack1
branch
from
d789784 to
9686510
Compare
|
I reverted |
|
Thank you! |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Sep 6, 2023
(ruby/openssl#586) String#unpack1 avoids the intermediate array created by String#unpack for single elements, while also making a call to Array#first/[0] unnecessary. ruby/openssl@8eb0715a42
anakinj
pushed a commit
to anakinj/openssl
that referenced
this pull request
Feb 17, 2024
String#unpack1 avoids the intermediate array created by String#unpack for single elements, while also making a call to Array#first/[0] unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String#unpack1 avoids the intermediate array created by String#unpack for single elements, while also making a call to Array#first/[0] unnecessary.