Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default IO#timeout if possible. #548

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Use default IO#timeout if possible. #548

merged 1 commit into from
Oct 7, 2022

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Oct 7, 2022

cc @rhenium

Apologies for this noise, and thanks for pointing out my mistake. It's been a long week.

@ioquatix ioquatix requested a review from rhenium October 7, 2022 10:09
rhenium
rhenium approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@rhenium rhenium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rhenium rhenium merged commit 2115cf3 into master Oct 7, 2022
@rhenium rhenium deleted the io-timeout-redux branch October 7, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhenium rhenium rhenium approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioquatix @rhenium