Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for specifying PKCS#12 MAC parameters #772

Closed
paihu opened this issue Jul 1, 2024 · 2 comments · Fixed by #788
Closed

Add support for specifying PKCS#12 MAC parameters #772

paihu opened this issue Jul 1, 2024 · 2 comments · Fixed by #788

Comments

@paihu
Copy link

paihu commented Jul 1, 2024

Issue #654 closed but it doesn't seem to be resolved.

Here's what we created using the legacy provider:

openssl pkcs12 -in xx.p12 -info -noout -legacy
Enter Import Password:
MAC: sha256, Iteration 1
MAC length: 32, salt length: 8
PKCS7 Encrypted data: pbeWithSHA1And40BitRC2-CBC, Iteration 2048
Certificate bag
PKCS7 Data
Shrouded Keybag: pbeWithSHA1And3-KeyTripleDES-CBC, Iteration 2048

It uses sha256 instead of sha1.

current OpenSSL::PKCS12.create not support -macalg

pyca/cryptography#7293 (comment)
@rhenium
Copy link
Member

rhenium commented Jul 3, 2024

You are right, the example code provided in #654 had another error and I skipped the main question.

Should we add a binding for PKCS12_set_mac()?

@paihu
Copy link
Author

paihu commented Jul 3, 2024

I think adding the PKCS12_set_mac() binding would be beneficial to maintain backward compatibility with legacy OpenSSL.

@rhenium rhenium changed the title Issue imporitng certificates created using OpenSSL::PKCS12 on macOS devices Add support for specifying PKCS#12 MAC parameters Jul 3, 2024
rhenium added a commit to rhenium/ruby-openssl that referenced this issue Aug 16, 2024
@rhenium
pkcs12: add PKCS12#set_mac
0c72f80 
Add a binding for PKCS12_set_mac() to set MAC parameters and
(re-)calculate MAC for the content.

This allows generating PKCS ruby#12 with consistent MAC parameters with
different OpenSSL versions. OpenSSL 3.0 changed the default hash
function used for HMAC and the KDF from SHA-1 to SHA-256.

Fixes: ruby#772
rhenium added a commit to rhenium/ruby-openssl that referenced this issue Aug 16, 2024
@rhenium
pkcs12: add PKCS12#set_mac
898c5f9 
Add a binding for PKCS12_set_mac() to set MAC parameters and
(re-)calculate MAC for the content.

This allows generating PKCS ruby#12 with consistent MAC parameters with
different OpenSSL versions. OpenSSL 3.0 changed the default hash
function used for HMAC and the KDF from SHA-1 to SHA-256.

Fixes: ruby#772
rhenium added a commit to rhenium/ruby-openssl that referenced this issue Aug 16, 2024
@rhenium
pkcs12: add PKCS12#set_mac
85d9f26 
Add a binding for PKCS12_set_mac() to set MAC parameters and
(re-)calculate MAC for the content.

This allows generating PKCS ruby#12 with consistent MAC parameters with
different OpenSSL versions. OpenSSL 3.0 changed the default hash
function used for HMAC and the KDF from SHA-1 to SHA-256.

Fixes: ruby#772
@rhenium rhenium mentioned this issue Aug 16, 2024
Merged
rhenium added a commit to rhenium/ruby-openssl that referenced this issue Oct 31, 2024
@rhenium
pkcs12: add PKCS12#set_mac
e25358d 
Add a binding for PKCS12_set_mac() to set MAC parameters and
(re-)calculate MAC for the content.

This allows generating PKCS ruby#12 with consistent MAC parameters with
different OpenSSL versions. OpenSSL 3.0 changed the default hash
function used for HMAC and the KDF from SHA-1 to SHA-256.

Fixes: ruby#772
rhenium added a commit to rhenium/ruby-openssl that referenced this issue Oct 31, 2024
@rhenium
pkcs12: add PKCS12#set_mac
137379d 
Add a binding for PKCS12_set_mac() to set MAC parameters and
(re-)calculate MAC for the content.

This allows generating PKCS ruby#12 with consistent MAC parameters with
different OpenSSL versions. OpenSSL 3.0 changed the default hash
function used for HMAC and the KDF from SHA-1 to SHA-256.

Fixes: ruby#772
rhenium added a commit to rhenium/ruby-openssl that referenced this issue Dec 7, 2024
@rhenium
pkcs12: add PKCS12#set_mac
d3e3338 
Add a binding for PKCS12_set_mac() to set MAC parameters and
(re-)calculate MAC for the content.

This allows generating PKCS ruby#12 with consistent MAC parameters with
different OpenSSL versions. OpenSSL 3.0 changed the default hash
function used for HMAC and the KDF from SHA-1 to SHA-256.

Fixes: ruby#772
rhenium added a commit to rhenium/ruby that referenced this issue Dec 21, 2024
@rhenium
[ruby/openssl] pkcs12: add PKCS12#set_mac
323eba6 
Add a binding for PKCS12_set_mac() to set MAC parameters and
(re-)calculate MAC for the content.

This allows generating PKCS ruby#12 with consistent MAC parameters with
different OpenSSL versions. OpenSSL 3.0 changed the default hash
function used for HMAC and the KDF from SHA-1 to SHA-256.

Fixes: ruby/openssl#772

ruby/openssl@f5ed2a74b6
rhenium added a commit to rhenium/ruby that referenced this issue Dec 21, 2024
@rhenium
[ruby/openssl] pkcs12: add PKCS12#set_mac
c79b435 
Add a binding for PKCS12_set_mac() to set MAC parameters and
(re-)calculate MAC for the content.

This allows generating PKCS ruby#12 with consistent MAC parameters with
different OpenSSL versions. OpenSSL 3.0 changed the default hash
function used for HMAC and the KDF from SHA-1 to SHA-256.

Fixes: ruby/openssl#772

ruby/openssl@f5ed2a74b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pkcs12: add PKCS12#set_mac rhenium/ruby-openssl
2 participants
@rhenium @paihu