-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Enhanced RDoc for copy_entry #76
Conversation
# | ||
# Copies a file system entry +src+ to +dest+. | ||
# If +src+ is a directory, this method copies its contents recursively. | ||
# This method preserves file types, c.f. symlink, directory... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to drop this information. If removing this text, we should mention elsewhere what is not supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
lib/fileutils.rb
Outdated
# | ||
# If +src+ is a directory, recursively copies +src+ to +dest+: | ||
# | ||
# system('tree src1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to use tree
, can we use --charset=ascii
to stick to 7-bit ASCII characters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be fine with me. Do you think we should use tree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does make it a little easier to see what is going on, so I don't have a problem using it here and in the documentation for other recursive copy methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does make it a little easier to see what is going on, so I don't have a problem using it here and in the documentation for other recursive copy methods.
Done.
I've omitted the |
This PR experiments with using
tree
to display directory structure (both src and dest). If we decide to keep this, we'll need to add a note about tree in the intro.