Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require version file relatively #35

Merged
merged 1 commit into from
May 2, 2019
Merged

Require version file relatively #35

merged 1 commit into from
May 2, 2019

Conversation

deivid-rodriguez
Copy link
Contributor

This avoids searching the LOAD_PATH and it also helps bundler when vendoring this gem because it won't need to do any modifications to the way it's required.

@hsbt hsbt merged commit 400574d into ruby:master May 2, 2019
ghost pushed a commit to rubygems/bundler that referenced this pull request May 12, 2019
7156: Improve fileutils require r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was there's [upstream changes in fileutils](ruby/fileutils#35).

### What is your fix for the problem, implemented in this PR?

My fix is to port the upstream changes, which consist of using `require_relative` everywhere.


Co-authored-by: David Rodríguez <[email protected]>
hsbt pushed a commit to rubygems/bundler-graph that referenced this pull request Oct 19, 2021
7156: Improve fileutils require r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was there's [upstream changes in fileutils](ruby/fileutils#35).

### What is your fix for the problem, implemented in this PR?

My fix is to port the upstream changes, which consist of using `require_relative` everywhere.


Co-authored-by: David Rodríguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants