Use FileUtils::VERSION in gemspec #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use already defined constant FileUtils::VERSION instead of duplicating the information. Also move FileUtils::VERSION into its own file.
|
@stomar I accidentally merged this. Can you create another pull-request? Sorry. |
|
See #25. |
|
It seems the issue still persists as in: #22 (comment). Any advice on fixing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #15.
Use already defined constant FileUtils::VERSION instead of duplicating
the information. Also move FileUtils::VERSION into its own file.
I moved FileUtils::VERSION into its own file to reduce warnings about already defined constants that happened with
gem build.In the gemspec, the require statement for the ruby core repository assumes that the gemfile and
version.rbare in the same directory (same structure as e.g. forthwait).Please do not yet merge, but update first to the latest core repository version of fileutils; this will probably cause a merge conflict and again break what I fixed in r64911; I will then fix the commit as necessary and repush the branch.
@hsbt