Use JRuby implementation for TruffleRuby

.github/workflows/ci.yml

@@ -26,13 +26,15 @@ jobs:
           - '3.2'
           - debug
           - jruby
+          - truffleruby
         include:
           - { os: windows-latest , ruby: mingw }
           - { os: windows-latest , ruby: mswin }
         exclude:
           - { os: macos-14  , ruby: '2.5' }
           - { os: windows-latest , ruby: '3.0' }
           - { os: windows-latest , ruby: debug }
+          - { os: windows-latest , ruby: truffleruby }
 
     steps:
       - uses: actions/checkout@v4

ext/fiddle/extconf.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 require 'mkmf'
 
-if RUBY_ENGINE == "jruby"
+unless RUBY_ENGINE == "ruby"
   File.write('Makefile', dummy_makefile("").join)
   return
 end

fiddle.gemspec

@@ -44,6 +44,7 @@ Gem::Specification.new do |spec|
     "lib/fiddle/pack.rb",
     "lib/fiddle/ruby.rb",
     "lib/fiddle/struct.rb",
+    "lib/fiddle/truffleruby.rb",
     "lib/fiddle/types.rb",
     "lib/fiddle/value.rb",
     "lib/fiddle/version.rb",

lib/fiddle/jruby.rb

@@ -149,7 +149,7 @@ def initialize(ptr, args, return_type, abi = DEFAULT, kwargs = nil)
       end
     end
 
-    def call(*args, &block);
+    def call(*args, &block)
       if @function.is_a?(FFI::VariadicInvoker)
         n_fixed_args = @args.size - 1
         n_fixed_args.step(args.size - 1, 2) do |i|
@@ -158,6 +158,17 @@ def call(*args, &block);
           end
           args[i] = Fiddle::JRuby.__ffi_type__(args[i])
         end
+      else
+        args.map! do |arg|
+          if arg.respond_to?(:to_ptr)
+            begin
+              arg = arg.to_ptr
+            end until arg.is_a?(FFI::Pointer) || !arg.respond_to?(:to_ptr)
+            arg
+          else
+            arg
+          end
+        end
       end
       result = @function.call(*args, &block)
       result = Pointer.new(result) if result.is_a?(FFI::Pointer)

lib/fiddle/truffleruby.rb

@@ -0,0 +1 @@
+require_relative 'jruby'

test/fiddle/test_closure.rb

@@ -6,6 +6,12 @@
 
 module Fiddle
   class TestClosure < Fiddle::TestCase
+    def setup
+      if RUBY_ENGINE == "truffleruby"
+        omit("FFI::Function don't accept #call-able object with TruffleRuby")
+      end
+    end
+
     def teardown
       super
       # We can't use ObjectSpace with JRuby.

test/fiddle/test_fiddle.rb

@@ -9,6 +9,9 @@ def test_nil_true_etc
     if RUBY_ENGINE == "jruby"
       omit("Fiddle::Q* aren't supported with JRuby")
     end
+    if RUBY_ENGINE == "truffleruby"
+      omit("Fiddle::Q* aren't supported with TruffleRuby")
+    end
 
     assert_equal Fiddle::Qtrue, Fiddle.dlwrap(true)
     assert_equal Fiddle::Qfalse, Fiddle.dlwrap(false)
@@ -30,6 +33,10 @@ def test_dlopen_linker_script_input_linux
     if Dir.glob("/usr/lib/*/libncurses.so").empty?
       omit("libncurses.so is needed")
     end
+    if RUBY_ENGINE == "truffleruby"
+      omit("Fiddle::Handle#file_name doesn't exist in TruffleRuby")
+    end
+
     # libncurses.so uses INPUT() on Debian GNU/Linux
     # $ cat /usr/lib/x86_64-linux-gnu/libncurses.so
     # INPUT(libncurses.so.6 -ltinfo)
@@ -44,6 +51,10 @@ def test_dlopen_linker_script_input_linux
 
   def test_dlopen_linker_script_group_linux
     omit("This is only for Linux") unless RUBY_PLATFORM.match?("linux")
+    if RUBY_ENGINE == "truffleruby"
+      omit("Fiddle::Handle#file_name doesn't exist in TruffleRuby")
+    end
+
     # libc.so uses GROUP() on Debian GNU/Linux
     # $ cat /usr/lib/x86_64-linux-gnu/libc.so
     # /* GNU ld script

test/fiddle/test_func.rb

@@ -64,6 +64,10 @@ def test_strtod
     end
 
     def test_qsort1
+      if RUBY_ENGINE == "truffleruby"
+        omit("TruffleRuby's FFI::Function don't accept #call-able object")
+      end
+
       closure_class = Class.new(Closure) do
         def call(x, y)
           Pointer.new(x)[0] <=> Pointer.new(y)[0]
@@ -74,16 +78,20 @@ def call(x, y)
         qsort = Function.new(@libc['qsort'],
                              [TYPE_VOIDP, TYPE_SIZE_T, TYPE_SIZE_T, TYPE_VOIDP],
                              TYPE_VOID)
-        buff = "9341"
+        untouched = "9341"
+        buff = +"9341"
         qsort.call(buff, buff.size, 1, callback)
         assert_equal("1349", buff)
 
         bug4929 = '[ruby-core:37395]'
-        buff = "9341"
+        buff = +"9341"
         under_gc_stress do
           qsort.call(buff, buff.size, 1, callback)
         end
         assert_equal("1349", buff, bug4929)
+
+        # Ensure the test didn't mutate String literals
+        assert_equal("93" + "41", untouched)
       end
     ensure
       # We can't use ObjectSpace with JRuby.

test/fiddle/test_function.rb

@@ -41,6 +41,9 @@ def test_need_gvl?
       if RUBY_ENGINE == "jruby"
         omit("rb_str_dup() doesn't exist in JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("rb_str_dup() doesn't work with TruffleRuby")
+      end
 
       libruby = Fiddle.dlopen(nil)
       rb_str_dup = Function.new(libruby['rb_str_dup'],
@@ -91,6 +94,10 @@ def test_call
     end
 
     def test_argument_count
+      if RUBY_ENGINE == "truffleruby"
+        omit("TruffleRuby's FFI::Function don't accept #call-able object")
+      end
+
       closure_class = Class.new(Closure) do
         def call one
           10 + one
@@ -112,6 +119,9 @@ def test_last_error
       if RUBY_ENGINE == "jruby"
         omit("Fiddle.last_error doesn't work with JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("Fiddle.last_error doesn't work with TruffleRuby")
+      end
 
       func = Function.new(@libc['strcpy'], [TYPE_VOIDP, TYPE_VOIDP], TYPE_VOIDP)
 
@@ -219,6 +229,9 @@ def test_no_memory_leak
       if RUBY_ENGINE == "jruby"
         omit("rb_obj_frozen_p() doesn't exist in JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("memory leak detection is fragile with TruffleRuby")
+      end
 
       if respond_to?(:assert_nothing_leaked_memory)
         rb_obj_frozen_p_symbol = Fiddle.dlopen(nil)["rb_obj_frozen_p"]

test/fiddle/test_handle.rb

@@ -12,6 +12,9 @@ def test_to_i
       if RUBY_ENGINE == "jruby"
         omit("Fiddle::Handle#to_i is unavailable with JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("Fiddle::Handle#to_i is unavailable with TruffleRuby")
+      end
 
       handle = Fiddle::Handle.new(LIBC_SO)
       assert_kind_of Integer, handle.to_i
@@ -21,6 +24,9 @@ def test_to_ptr
       if RUBY_ENGINE == "jruby"
         omit("Fiddle::Handle#to_i is unavailable with JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("Fiddle::Handle#to_i is unavailable with TruffleRuby")
+      end
 
       handle = Fiddle::Handle.new(LIBC_SO)
       ptr = handle.to_ptr
@@ -37,6 +43,9 @@ def test_static_sym
       if RUBY_ENGINE == "jruby"
         omit("We can't assume static symbols with JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("We can't assume static symbols with TruffleRuby")
+      end
 
       begin
         # Linux / Darwin / FreeBSD
@@ -136,6 +145,9 @@ def test_file_name
       if RUBY_ENGINE == "jruby"
         omit("Fiddle::Handle#file_name doesn't exist in JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("Fiddle::Handle#file_name doesn't exist in TruffleRuby")
+      end
 
       file_name = Handle.new(LIBC_SO).file_name
       if file_name
@@ -158,6 +170,9 @@ def test_NEXT
       if RUBY_ENGINE == "jruby"
         omit("Fiddle::Handle::NEXT doesn't exist in JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("Fiddle::Handle::NEXT doesn't exist in TruffleRuby")
+      end
 
       begin
         # Linux / Darwin

test/fiddle/test_import.rb

@@ -157,6 +157,9 @@ def test_io()
       if RUBY_ENGINE == "jruby"
         omit("BUILD_RUBY_PLATFORM doesn't exist in JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("BUILD_RUBY_PLATFORM doesn't exist in TruffleRuby")
+      end
 
       if( RUBY_PLATFORM != BUILD_RUBY_PLATFORM ) || !defined?(LIBC.fprintf)
         return

test/fiddle/test_pointer.rb

@@ -14,6 +14,9 @@ def test_can_read_write_memory
       if RUBY_ENGINE == "jruby"
         omit("Fiddle::Pointer.{read,write} don't exist in JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("Fiddle::Pointer.{read,write} don't exist in TruffleRuby")
+      end
 
       # Allocate some memory
       Fiddle::Pointer.malloc(Fiddle::SIZEOF_VOIDP, Fiddle::RUBY_FREE) do |pointer|
@@ -116,6 +119,9 @@ def test_inspect
       if RUBY_ENGINE == "jruby"
         omit("Fiddle::Pointer#inspect is incompatible on JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("Fiddle::Pointer#inspect is incompatible on TruffleRuby")
+      end
 
       ptr = Pointer.new(0)
       inspect = ptr.inspect
@@ -135,6 +141,9 @@ def test_to_ptr_io
       if RUBY_ENGINE == "jruby"
         omit("Fiddle::Pointer.to_ptr(IO) isn't supported with JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("Fiddle::Pointer.to_ptr(IO) isn't supported with TruffleRuby")
+      end
 
       Pointer.malloc(10, Fiddle::RUBY_FREE) do |buf|
         File.open(__FILE__, 'r') do |f|
@@ -186,6 +195,9 @@ def test_ref_ptr
       if RUBY_ENGINE == "jruby"
         omit("Fiddle.dlwrap([]) isn't supported with JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("Fiddle.dlwrap([]) isn't supported with TruffleRuby")
+      end
 
       ary = [0,1,2,4,5]
       addr = Pointer.new(dlwrap(ary))
@@ -198,6 +210,9 @@ def test_to_value
       if RUBY_ENGINE == "jruby"
         omit("Fiddle.dlwrap([]) isn't supported with JRuby")
       end
+      if RUBY_ENGINE == "truffleruby"
+        omit("Fiddle.dlwrap([]) isn't supported with TruffleRuby")
+      end
 
       ary = [0,1,2,4,5]
       addr = Pointer.new(dlwrap(ary))