Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ractor support #139

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Ractor support #139

merged 7 commits into from
Oct 11, 2024

Conversation

nobu
Copy link
Member

@nobu nobu commented May 4, 2024

No description provided.

@@ -236,5 +236,15 @@ VALUE rb_fiddle_new_function(VALUE address, VALUE arg_types, VALUE ret_type);
typedef void (*rb_fiddle_freefunc_t)(void*);
VALUE rb_fiddle_ptr_new_wrap(void *ptr, long size, rb_fiddle_freefunc_t func, VALUE wrap0, VALUE wrap1);

enum {
FIDDLE_DEFAULT_TYPED_DATA_FALGS = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/FALGS/FLAGS

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
I've fixed it.

@kou kou merged commit 91d0ea9 into ruby:master Oct 11, 2024
47 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Oct 16, 2024
kou added a commit that referenced this pull request Nov 9, 2024
GitHub: fix GH-159

It's used by FFI test. So Symbol may be used by other use cases.

GH-139 introduced the "Function name is String" limitation. This
commit removed the limitation.

Reported by Mamoru TASAKA. Thanks!!!
matzbot pushed a commit to ruby/ruby that referenced this pull request Nov 11, 2024
GitHub: fix ruby/fiddle#159

It's used by FFI test. So Symbol may be used by other use cases.

ruby/fiddle#139 introduced the "Function name is String" limitation. This
commit removed the limitation.

Reported by Mamoru TASAKA. Thanks!!!

ruby/fiddle@cea30fe5f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants