Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use bundler-cache #14

Merged
merged 1 commit into from
Dec 11, 2021
Merged

CI: use bundler-cache #14

merged 1 commit into from
Dec 11, 2021

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Oct 14, 2021

This PR uses the bundler-cache feature of the Ruby-maintained Action ruby/setup-ruby.

See ruby/setup-ruby parameters declaration for more information.


In order to get this to run green:

  • Use the newest-possible RubyGems for old Ruby versions
  • Use a newer-than-troublesome version of fileutils gem when running tests

@hsbt
Copy link
Member

hsbt commented Dec 9, 2021

It caused by activating etc by RubyGems or Bundler each versions of Ruby.

@olleolleolle
Copy link
Contributor Author

I see. Tricky situation, of course.

@deivid-rodriguez
Copy link

I figured it out. test-unit requires fileutils, and old fileutils versions (shipped with old rubies) used to require etc. I proposed a PR to test-unit that maybe can avoid the fileutils require there, but I think another workaround would be to add gem 'fileutils', '>= 1.2.0' to the Gemfile, to ensure that a version including ruby/fileutils#34 is used.

@olleolleolle
Copy link
Contributor Author

@hsbt, @deivid-rodriguez Thanks, now we are at green.

@deivid-rodriguez
Copy link

deivid-rodriguez commented Dec 9, 2021

@olleolleolle My PR to test-unit was merged and released, so I think you can drop the change now and CI should be green.

@deivid-rodriguez
Copy link

Actually fileutils is also loaded by mkmf.rb during compilation of the gem, so the workaround is still needed.

@olleolleolle olleolleolle force-pushed the olleolleolle-patch-1-1 branch from 9aaf6e6 to e45305b Compare December 10, 2021 12:11
@olleolleolle
Copy link
Contributor Author

I reinstated the workaround, and then turned the commits in a single commit.

@hsbt
Copy link
Member

hsbt commented Dec 11, 2021

@olleolleolle Thanks. We will remove the additional dependency after drop to support Ruby 2.5 and 2.6.

@hsbt hsbt merged commit 0484ac4 into master Dec 11, 2021
@hsbt hsbt deleted the olleolleolle-patch-1-1 branch December 11, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants