Skip to content

Commit

Permalink
Merge pull request #42 from ruby/feature-16495
Browse files Browse the repository at this point in the history
[Feature #16495] Do not include a backtick in error messages and backtraces
  • Loading branch information
hsbt authored Feb 16, 2024
2 parents 80ede6b + c948016 commit 2fd2a1b
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions test/test_error_highlight.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,31 @@ def teardown
end
end

begin
method_not_exist
rescue NameError
if $!.message.include?("`")
def preprocess(msg)
msg
end
else
def preprocess(msg)
msg.sub("`", "'")
end
end
end

if Exception.method_defined?(:detailed_message)
def assert_error_message(klass, expected_msg, &blk)
omit unless klass < ErrorHighlight::CoreExt
err = assert_raise(klass, &blk)
assert_equal(expected_msg.chomp, err.detailed_message(highlight: false).sub(/ \((?:NoMethod|Name)Error\)/, ""))
assert_equal(preprocess(expected_msg).chomp, err.detailed_message(highlight: false).sub(/ \((?:NoMethod|Name)Error\)/, ""))
end
else
def assert_error_message(klass, expected_msg, &blk)
omit unless klass < ErrorHighlight::CoreExt
err = assert_raise(klass, &blk)
assert_equal(expected_msg.chomp, err.message)
assert_equal(preprocess(expected_msg).chomp, err.message)
end
end

Expand Down

0 comments on commit 2fd2a1b

Please sign in to comment.