Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skipping next breakpoint unexpectedly #1132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix skipping next breakpoint unexpectedly #1132

wants to merge 1 commit into from

Conversation

iberianpig
Copy link

Description

With this PR, even if you press Enter key repeatedly before reaching the breakpoint, continue will not be executed automatically.

Issue

When you reach a breakpoint in the debugger once, proceed with 'c',
and then press 'Enter' before reaching the next breakpoint, the next
breakpoint is skipped. (Issue: #1098)

reproduce script:

require 'debug'

def test_issue_key_strokes
  puts 'Please press "C" once and continue'
  debugger # Stop here.

  puts 'then press "Retern" once within 5 seconds.'
  sleep 5

  puts 'folloing break point will be skipped'

  debugger # Skipped! It should stop here.
end

puts 'Start'
test_issue_key_strokes
puts 'End'

@iberianpig
Fix skipping next breakpoint unexpectedly
06fb612 
When you reach a breakpoint in the debugger once, proceed with 'c',
and then press 'Enter' before reaching the next breakpoint, the next
breakpoint is skipped. (Issue: ruby#1098)

reproduce script:
```ruby
require 'debug'

def test_issue_key_strokes
  puts 'Please press "C" once and continue'
  debugger # Stop here.

  puts 'then press "Retern" once within 5 seconds.'
  sleep 5

  puts 'folloing break point will be skipped'

  debugger # Skipped! It should stop here.
end

puts 'Start'
test_issue_key_strokes
puts 'End'
```
@iberianpig iberianpig marked this pull request as ready for review January 28, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iberianpig