Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default exception and its backtrace logging #352

Closed
unijewski opened this issue Apr 7, 2017 · 2 comments
Closed

Default exception and its backtrace logging #352

unijewski opened this issue Apr 7, 2017 · 2 comments

Comments

@unijewski
Copy link

unijewski commented Apr 7, 2017

Hello. So far I used Sidekiq with ActiveJob where all exceptions were logging with their backtrace, regardless of using rescue_from and raising errors. After migrating to Shoryuken by default I'm getting only a short status information, e.g.

2017-04-07T16:36:04Z 4163 TID-oxciegseg ActiveJob/ExampleJob/my_queue/9623e444-9216-4be3-b4a6-6f85ed3bcfe6 INFO: failed in: 1317.8410000000001 ms

unless I perform explicitly:

Shoryuken.logger.error exception
Shoryuken.logger.error exception.backtrace.join("\n")

in a rescue_from block. Is there a way to log that everywhere by default?

phstc pushed a commit that referenced this issue Apr 10, 2017
@phstc
Copy link
Collaborator

phstc commented Apr 10, 2017

Hi @unijewski

Good catch. It seems it got mistakenly dropped in v3.

I'm adding it back here #355.

It will be back in v3.0.5 (soon this week).

@unijewski
Copy link
Author

Cool, thanks! 👍

phstc added a commit that referenced this issue Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants