Simplify mkmf-rice, part 2 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like removing the |
Merged
cfis
reviewed
Oct 28, 2024
| @@ -1,7 +1,7 @@ | |||
| require 'mkmf' | |||
|
|
|||
| IS_MSWIN = RbConfig::CONFIG['host_os'].match?(/mswin/) | |||
| IS_MINGW = RbConfig::CONFIG['host_os'].match?(/mingw/) | |||
| IS_MSWIN = /mswin/ =~ RUBY_PLATFORM | |||
There was a problem hiding this comment.
Oh I meant actually using the $constants defined my mkmf already. Unless their and not accessible from the extconf.rb file?
There was a problem hiding this comment.
Ah, seems like they should be accessible. Feel free to update in a follow-up commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more changes:
IS_MSWINandIS_MINGWdetection to match Ruby as suggested in Simplify mkmf-rice #211ld: warning: ignoring duplicate libraries: '-lc++'on Mac (and addsmacos-13to CI for this and future changes)Removes thecpp_commandoverride (the code hasn't been updated since the bug was filed, but will see if it compiles on CI)