add support for experimental filesystem - fixes jasonroelofs/rice/197 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekendalmiller
commented
Jan 16, 2024
| @@ -126,5 +126,5 @@ def cpp_command(outfile, opt="") | |||
| if IS_DARWIN | |||
| have_library('c++') | |||
| elsif !IS_MSWIN | |||
| have_library('stdc++') | |||
| have_library('stdc++fs') | |||
There was a problem hiding this comment.
This seems to be OK to always do, even on newer GCC like 11.4 from Ubuntu 22.04
thekendalmiller
force-pushed
the
support_experimental_fs
branch
from
cfd1096 to
711f9b3
Compare
thekendalmiller
changed the title
thekendalmiller
changed the title
thekendalmiller
force-pushed
the
support_experimental_fs
branch
from
711f9b3 to
2bef239
Compare
|
Using it to detect what's supported in c++17 doesn't help when c++17 doesn't have back to the drawing board...sorry for the noise |
|
I don't think you need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197
WIP - still doesn't work on amazon linux consitently?