Fix enum hash equality #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protobuf::Enum delegates methods to Fixnum, which has a custom hash equality method (`eql?`). This causes enum values to be equivalent when using `==`, `===`, `equals?`, but not `eql?`**: 2.3.7 :002 > Test::EnumTestType::ZERO.eql?(::Test::EnumTestType::ZERO) => false However, they are equilvalent to their tag value: 2.3.7 :002 > Test::EnumTestType::ZERO.eql?(::Test::EnumTestType::ZERO.tag) => true Use the hash equality implementation from Object#eql?, which is equivalent to == instead. **The implementation changed in Ruby 2.5, so this only affects Ruby versions less than v2.5.
liveh2o
force-pushed
the
ah/fix_enum_hash_equality
branch
from
27dae6d to
da5b844
Compare
|
Released as |
Merged
|
Released in v3.8.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf::Enum delegates methods to Fixnum, which has a custom hash equality method (
eql?). This causes enum values to be equivalent when using==,===,equals?, but noteql?**:However, they are equilvalent to their tag value:
Use the hash equality implementation from
Object#eql?, which is equivalent to==instead.**The implementation changed in Ruby 2.5, so this only affects Ruby versions less than v2.5.