already loading field on define and should not need to calcualte the … #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| fail TypeError, "Unacceptable value #{val} for field #{field.name} of type #{field.type_class}" | ||
| end | ||
| rescue NoMethodError => ex |
There was a problem hiding this comment.
Interesting that we had no test coverage for this behavior. In either case we are raising an exception and we can let the caller decider if they want to log and convert the error type themselves 👍
|
If all the travis checks pass I say |
abrandoned
added a commit
that referenced
this pull request
Feb 6, 2016
…ed_on_load already loading field on define and should not need to calcualte the …
|
👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tag encoding at runtime
@film42 per our discussion on knowing the tag Varint at load time; we can store the encoded tag value on the field object in the definition and read it directly during the serialization phase instead of calculating the varint again
removes ~1.5 seconds on 15 second 100_000 object serialize
@film42