Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow snake_case module and class naming in generated proto files #290

Closed
wants to merge 1 commit into from

Conversation

film42
Copy link
Member

@film42 film42 commented Feb 1, 2016

Resolves the following:

Offenses:

spec/support/protos/google_unittest.pb.rb:15:8: C: Use CamelCase for classes and modules.
module Protobuf_unittest
       ^^^^^^^^^^^^^^^^^
spec/support/protos/google_unittest.pb.rb:69:9: C: Use CamelCase for classes and modules.
  class OptionalGroup_extension < ::Protobuf::Message; end
        ^^^^^^^^^^^^^^^^^^^^^^^
spec/support/protos/google_unittest.pb.rb:70:9: C: Use CamelCase for classes and modules.
  class RepeatedGroup_extension < ::Protobuf::Message; end
        ^^^^^^^^^^^^^^^^^^^^^^^
spec/support/protos/google_unittest.pb.rb:367:9: C: Use CamelCase for classes and modules.
  class OptionalGroup_extension
        ^^^^^^^^^^^^^^^^^^^^^^^
spec/support/protos/google_unittest.pb.rb:371:9: C: Use CamelCase for classes and modules.
  class RepeatedGroup_extension
        ^^^^^^^^^^^^^^^^^^^^^^^
spec/support/protos/google_unittest_import.pb.rb:14:8: C: Use CamelCase for classes and modules.
module Protobuf_unittest_import
       ^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/protos/google_unittest_import_public.pb.rb:8:8: C: Use CamelCase for classes and modules.
module Protobuf_unittest_import
       ^^^^^^^^^^^^^^^^^^^^^^^^

cc @abrandoned @mmmries @liveh2o @brianstien

@nerdrew
Copy link
Contributor

nerdrew commented Feb 1, 2016

Same as #287. Want me to close mine?

@film42
Copy link
Member Author

film42 commented Feb 1, 2016

Whoops! Sorry about that @nerdrew . I'll close mine!

@film42 film42 closed this Feb 1, 2016
@film42 film42 deleted the gt/dealwithrubocop branch February 1, 2016 22:01
@film42
Copy link
Member Author

film42 commented Feb 1, 2016

@nerdrew I merged yours. Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants