consolidate test protos to spec/support/protos #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nerdrew
commented
Jan 27, 2016
nerdrew
commented
- add SUPPORT_PATH, PROTOS_PATH helpers in specs
- refresh unittest protos from upstream
- add SUPPORT_PATH, PROTOS_PATH helpers in specs - refresh unittest protos from upstream
| repeated TestAllTypes ext1 = 1000; | ||
| repeated TestAllTypes ext2 = 1001; | ||
| } | ||
| required TestAllTypes required_all_types = 1; | ||
| optional TestAllTypes optional_all_types = 2; | ||
| repeated TestAllTypes repeated_all_types = 3; | ||
| // TODO: Support groups |
There was a problem hiding this comment.
are groups supported? or should this remain commented out?
There was a problem hiding this comment.
Hmmm. Strange. It is able to read the proto and the generated code looks right. Lemme dig up the protobuf docs on group.
Leaving it as is. It seems to work fine.
abrandoned
added a commit
that referenced
this pull request
Feb 1, 2016
…tream consolidate test protos to spec/support/protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.