Ensure the ping port is timed out after a reasonable amount of time #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should a server's ping port get jammed, overwhelmed, or access a port that is not open, then the ping port check will block until the TCPSocket default timeout rescues the blocked request. Instead, we can wrap Socket to add a reasonable timeout to ping port checks. By default, the timeout is set to 5 seconds, but you can customize this by setting the "PB_RPC_PING_PORT_TIMEOUT" environment variable.
|
Build failing looks like a bundler issue :dealwithbundler: |
| end | ||
|
|
||
| def timeout | ||
| @timeout ||= begin |
There was a problem hiding this comment.
wouldn't we want the timeout to be in millis? (seconds seems like a long time)
abrandoned
added a commit
that referenced
this pull request
Feb 1, 2016
Ensure the ping port is timed out after a reasonable amount of time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should a server's ping port get jammed, overwhelmed, or access a port that is not open, then the ping port check will block until the TCPSocket default timeout rescues the blocked request. Instead, we can wrap Socket to add a reasonable timeout to ping port checks. By default, the timeout is set to 5 seconds, but you can customize this by setting the
PB_RPC_PING_PORT_TIMEOUTenvironment variable.There is probably some more work that can be done here, but I wanted this PR to be about solving this ping port problem before I make a few more changes, like using
PB_RPC_PING_PORTinside of the newPingclass.cc @abrandoned @quixoten @mmmries @liveh2o @brianstien @localshred