Remove GC start/stop around requests #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the deprecation notice is right, but seems odd to remove the behavior alongside the warning. Should we release a deprecation notice and when releasing 4.0 remove the feature? |
|
@localshred That's probably a better solution. |
I think this was an MRI relic that was never removed. In a threaded environment, it doesn't make sense to start and stop the GC per request. It just doesn't work.
film42
force-pushed
the
gt/remove_gc_stuff
branch
from
efd3512 to
3addd60
Compare
|
@localshred done. |
|
👍 sounds like a good plan to me I vote we |
|
WOO!! |
|
I can merge, but won't be able to cut a new version. Little help? |
film42
added a commit
that referenced
this pull request
Feb 1, 2016
Remove GC start/stop around requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the
gc_pause_requestoption from the CLI, and removes thegc_pauseblocks around the process request methods. This may have been a speedup on MRI, but in a real threaded env, this functionality doesn't have the same guarantees. I vote we 🔥 it.cc @abrandoned @localshred @liveh2o @mmmries