Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #268, here's the results of benchmarking C vs pure Ruby. For the sake of being thorough, I also tested the variant used in the other protobuf gem (which was related to what @jjowdy) suggested, and it performed worst.
I also tested the C encoder in the varint gem, and it appears to be slower. This might be because with how protobuf is implemented, we need to create a
StringIO
class, rewind it, and then callread
in order to get. Rewriting things might speed it up, but that's outside of what I'm looking to do in this PR.Thanks @hollow and @codekitchen for the extension!