Replace Protobuf::Deprecator with a thin wrapper on AS::Deprecation #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did a bit more work on this - ended up replacing our bespoke deprecator module with a subclass of |
We use the much better functionality from AS::Deprecation
| end | ||
| end | ||
| end | ||
| ::Protobuf.deprecator.define_deprecated_methods(Numeric, :value => :to_int) |
|
Looks good to me Will review other PRs tonight and figure out the order we want all this merged (if order indeed will matter). |
|
order probably matters, but there's likely no order that is rebase-free. if this one LGTY, go ahead and merge it, and i'll rebase the others |
tamird
changed the title
localshred
added a commit
that referenced
this pull request
Dec 2, 2014
Replace Protobuf::Deprecator with a thin wrapper on AS::Deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@localshred