Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

06/25/2023 passkeys controller documentation #39

Conversation

johalloran01
Copy link
Contributor

No description provided.

Copy link
Contributor

@tcannonfodder tcannonfodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started an editing pass, but need to review with fresh eyes

* Fix typos, streamline & clarify behaviors
* These should be `resource_name`, since the controller could be
	handling authentication for a non-user resource
Copy link
Contributor

@tcannonfodder tcannonfodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made an editing pass; tried a git rebase 3x and it was a nightmare, so the history will be committed as-is

@tcannonfodder tcannonfodder linked an issue Jul 3, 2023 that may be closed by this pull request
1 task
@tcannonfodder tcannonfodder merged commit 614f7f4 into ruby-passkeys:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for passkey registration
2 participants